feat(roles-permissions): add id-based management methods and role_ids search#1456
Merged
feat(roles-permissions): add id-based management methods and role_ids search#1456
Conversation
…earch Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 |
2 tasks
![shuni-bot-dev[bot]](https://avatars.githubusercontent.com/u/97479186?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)descope/management/permission.py
descope/management/role.py
|
…ord id arg; add ids to delete_batch Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…d/role_ids kwargs only Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yosiharan
changed the title
…s; zero breaking changes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yosiharan
changed the title
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dorsha
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Required for:
https://github.com/descope/etc/issues/15352
Related PRs
Upstream PRs
Downstream PRs
Description
Adds explicit
_by_idmethods alongside existing ones for Roles and Permissions CRUD, keeping the API clean, simple and fully backwards compatible.Permission — new methods:
update_by_id(id, new_name, description)delete_by_id(id)delete_batch_by_ids(ids)Role — new methods:
update_by_id(id, new_name, description, permission_names, tenant_id, default, private)delete_by_id(id, tenant_id)delete_batch_by_ids(role_ids, tenant_id)search(..., role_ids)— new optional filter param (additive, backward compatible)Must